Skip to content

Conversation

@jim-portegies
Copy link
Contributor

coq-waterproof.3.1.0+9.0

Coq proofs in a style that resembles non-mechanized mathematical proofs
The Waterproof plugin for the Coq proof assistant allows you to write Coq proofs in a style that resembles handwritten mathematical proofs, designed to help university students with learning how to prove mathematical statements.



🐫 Pull-request generated by opam-publish v2.2.0

@jim-portegies jim-portegies marked this pull request as draft November 3, 2025 19:48
@jim-portegies jim-portegies marked this pull request as ready for review November 4, 2025 09:58
@jim-portegies
Copy link
Contributor Author

I just don't know how to tell that the msys2 build is not expected to pass (because it fails on a dependency)

@jmid
Copy link
Member

jmid commented Nov 4, 2025

I think it is fine to leave it. MSys2 is still a relatively new addition, so more often than not it triggers red CI lights.

The error itself looks related to the one from #28636 for which ocaml/ocamlfind#112 provides a solution.
If you a curious to investigate, you can try adding a quick pin of that patched ocamlfind like this one: jmid#25

@jim-portegies
Copy link
Contributor Author

I might want to investigate later, but for now I'm happy to leave it as is.

Copy link
Member

@jmid jmid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

I see you're adding x-maintained: false to old versions so that these can get archived - thanks for doing that! 🙏 I suspect you choosing to do so over an x-maintenance-intent: [("latest")] has to do with the version interplay ("3.1.0 with Roq 9.0") for which you may also want to maintain "3.1.0 with Roq 8.9", which may not be easily expressed with x-maintenance-intent. Does that sound about right?

@jim-portegies
Copy link
Contributor Author

Thanks! Yes, that's exactly the reason for adding x-maintained: false.

@mseri
Copy link
Member

mseri commented Nov 4, 2025

Thanks a lot!

@mseri mseri merged commit 56e7d9d into ocaml:master Nov 4, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants